[PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon

Sam Ravnborg sam at ravnborg.org
Sun Nov 29 21:45:17 UTC 2020


On Sun, Nov 29, 2020 at 11:03:25AM +0100, Thomas Zimmermann wrote:
> 
> 
> Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
> > Replacing DPRINTK() statements with pr_debug fixes set but not used
> > warnings.  And moves to a more standard logging setup at the same time.
> > 
> > v2:
> >    - Fix indent (Joe)
> > 
> > Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> > Cc: Joe Perches <joe at perches.com>
> > Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
> > Cc: Sam Ravnborg <sam at ravnborg.org>
> > Cc: Jiri Slaby <jirislaby at kernel.org>
> > Cc: Peilin Ye <yepeilin.cs at gmail.com>
> > Cc: Tetsuo Handa <penguin-kernel at I-love.SAKURA.ne.jp>
> > Cc: George Kennedy <george.kennedy at oracle.com>
> > Cc: Nathan Chancellor <natechancellor at gmail.com>
> > Cc: Peter Rosin <peda at axentia.se>
> > ---
> >   drivers/video/fbdev/core/fbcon.c | 25 ++++++++-----------------
> >   1 file changed, 8 insertions(+), 17 deletions(-)
> > 
> > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> > index bf61598bf1c3..44a5cd2f54cc 100644
> > --- a/drivers/video/fbdev/core/fbcon.c
> > +++ b/drivers/video/fbdev/core/fbcon.c
> > @@ -56,8 +56,6 @@
> >    *  more details.
> >    */
> > -#undef FBCONDEBUG
> > -
> 
> I guess this was added for quick debugging during development. Anyway, I
> never liked these kinds of hacks.
> 
> Acked-by: Thomas Zimmermann <tzimmermann at suse.de>

Thanks, applied to drm-misc-next.

	Sam


More information about the dri-devel mailing list