[PATCH v1 2/3] drm/tiny: Add driver for ili9341 with parallel bus

Mon Nov 30 08:54:47 UTC 2020

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.10-rc6 next-20201127]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/mdurnev-gmail-com/drm-mipi-dbi-Type-B-bus-support-drm-tiny-MRB2801/20201130-142812
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 09162bc32c880a791c6c0668ce0745cf7958f576
config: arm64-randconfig-r024-20201130 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5883e05578f8008b00a270e8f4ebe9cb7e06a6b6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review mdurnev-gmail-com/drm-mipi-dbi-Type-B-bus-support-drm-tiny-MRB2801/20201130-142812
        git checkout 5883e05578f8008b00a270e8f4ebe9cb7e06a6b6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/drm_mipi_dbi.c: In function 'mipi_dbi_gpio_init':
>> drivers/gpu/drm/drm_mipi_dbi.c:1266:6: error: implicit declaration of function 'mipi_dbi_machine_little_endian' [-Werror=implicit-function-declaration]
    1266 |  if (mipi_dbi_machine_little_endian())
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/mipi_dbi_machine_little_endian +1266 drivers/gpu/drm/drm_mipi_dbi.c

12265315ac41a3e Mikhail Durnev 2020-11-30  1234  
12265315ac41a3e Mikhail Durnev 2020-11-30  1235  /**
12265315ac41a3e Mikhail Durnev 2020-11-30  1236   * mipi_dbi_gpio_init - Initialize MIPI DBI Type B interface implemented via GPIO
12265315ac41a3e Mikhail Durnev 2020-11-30  1237   * @dbi: MIPI DBI structure to initialize
12265315ac41a3e Mikhail Durnev 2020-11-30  1238   * @dc: D/C gpio
12265315ac41a3e Mikhail Durnev 2020-11-30  1239   * @wr: W/R gpio
12265315ac41a3e Mikhail Durnev 2020-11-30  1240   * @db: DB gpios
12265315ac41a3e Mikhail Durnev 2020-11-30  1241   * @wr_up_delay: Delay after setting DB and before changing W/R from low to high
12265315ac41a3e Mikhail Durnev 2020-11-30  1242   * @wr_down_delay: Delay after changing W/R from low to high
12265315ac41a3e Mikhail Durnev 2020-11-30  1243   *
12265315ac41a3e Mikhail Durnev 2020-11-30  1244   * This function sets &mipi_dbi->command, enables &mipi_dbi->read_commands for the
12265315ac41a3e Mikhail Durnev 2020-11-30  1245   * usual read commands. It should be followed by a call to mipi_dbi_dev_init() or
12265315ac41a3e Mikhail Durnev 2020-11-30  1246   * a driver-specific init.
12265315ac41a3e Mikhail Durnev 2020-11-30  1247   *
12265315ac41a3e Mikhail Durnev 2020-11-30  1248   * Returns:
12265315ac41a3e Mikhail Durnev 2020-11-30  1249   * Zero on success, negative error code on failure.
12265315ac41a3e Mikhail Durnev 2020-11-30  1250   */
12265315ac41a3e Mikhail Durnev 2020-11-30  1251  int mipi_dbi_gpio_init(struct mipi_dbi *dbi, struct gpio_desc *dc,
12265315ac41a3e Mikhail Durnev 2020-11-30  1252  		      struct gpio_desc *wr, struct gpio_descs *db,
12265315ac41a3e Mikhail Durnev 2020-11-30  1253  		      unsigned long wr_up_delay, unsigned long wr_down_delay)
12265315ac41a3e Mikhail Durnev 2020-11-30  1254  {
12265315ac41a3e Mikhail Durnev 2020-11-30  1255  	dbi->spi = NULL; /* Type B uses GPIO lines rather than SPI */
12265315ac41a3e Mikhail Durnev 2020-11-30  1256  
12265315ac41a3e Mikhail Durnev 2020-11-30  1257  	dbi->read_commands = mipi_dbi_dcs_read_commands;
12265315ac41a3e Mikhail Durnev 2020-11-30  1258  	dbi->command = mipi_dbi_gpio_command;
12265315ac41a3e Mikhail Durnev 2020-11-30  1259  
12265315ac41a3e Mikhail Durnev 2020-11-30  1260  	dbi->dc = dc;
12265315ac41a3e Mikhail Durnev 2020-11-30  1261  	dbi->wr = wr;
12265315ac41a3e Mikhail Durnev 2020-11-30  1262  	dbi->db = db;
12265315ac41a3e Mikhail Durnev 2020-11-30  1263  	dbi->wr_up_delay = wr_up_delay;
12265315ac41a3e Mikhail Durnev 2020-11-30  1264  	dbi->wr_down_delay = wr_down_delay;
12265315ac41a3e Mikhail Durnev 2020-11-30  1265  
12265315ac41a3e Mikhail Durnev 2020-11-30 @1266  	if (mipi_dbi_machine_little_endian())
12265315ac41a3e Mikhail Durnev 2020-11-30  1267  		dbi->swap_bytes = true;
12265315ac41a3e Mikhail Durnev 2020-11-30  1268  
12265315ac41a3e Mikhail Durnev 2020-11-30  1269  	mutex_init(&dbi->cmdlock);
12265315ac41a3e Mikhail Durnev 2020-11-30  1270  
12265315ac41a3e Mikhail Durnev 2020-11-30  1271  	return 0;
12265315ac41a3e Mikhail Durnev 2020-11-30  1272  }
12265315ac41a3e Mikhail Durnev 2020-11-30  1273  EXPORT_SYMBOL(mipi_dbi_gpio_init);
12265315ac41a3e Mikhail Durnev 2020-11-30  1274  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 37164 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201130/f4e06d9c/attachment-0001.gz>