[PATCH v2 08/28] video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay

[Thomas Zimmermann]

Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
> Fix W=1 warning by commenting unused SiS_TVDelay* variables.
> 
> The SiS_TVDelay* variables seem to contain some magic numbers
> so looks like data worth keeping around but not as code we build.

I would remove it. sisfb is broken beyond repair and no one's going to 
try to use it anyway. In any case

Acked-by: Thomas Zimemrmann <tzimmermann at suse.de>

> 
> v2:
>    - Update subject (Lee)
> 
> Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> Cc: Thomas Winischhofer <thomas at winischhofer.net>
> Cc: Lee Jones <lee.jones at linaro.org>
> ---
>   drivers/video/fbdev/sis/oem310.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/video/fbdev/sis/oem310.h b/drivers/video/fbdev/sis/oem310.h
> index 8fce56e4482c..ed28755715ce 100644
> --- a/drivers/video/fbdev/sis/oem310.h
> +++ b/drivers/video/fbdev/sis/oem310.h
> @@ -200,6 +200,7 @@ static const unsigned char SiS310_TVDelayCompensation_651302LV[] =	/* M650, 651,
>   	0x33,0x33
>   };
>   
> +#if 0 /* Not used */
>   static const unsigned char SiS_TVDelay661_301[] =			/* 661, 301 */
>   {
>   	0x44,0x44,
> @@ -219,6 +220,7 @@ static const unsigned char SiS_TVDelay661_301B[] =			/* 661, 301B et al */
>   	0x44,0x44,
>   	0x44,0x44
>   };
> +#endif
>   
>   static const unsigned char SiS310_TVDelayCompensation_LVDS[] =		/* LVDS */
>   {
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201130/07d3f6a9/attachment.sig>