[PATCH v2 11/28] video: fbdev: via: Fix set but not used warning for mode_crt_table

[Thomas Zimmermann]

Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
> Fix warning by deleting the variable. The function call
> viafb_get_best_mode() were verified to have no side-effects,

s/were/was

> and thus could be dropped too.
> 
> v2:
>    - Update subject (Lee)
> 
> Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> Cc: Florian Tobias Schandinat <FlorianSchandinat at gmx.de>
> Cc: linux-fbdev at vger.kernel.org
> Cc: Lee Jones <lee.jones at linaro.org>

Acked-by: Thomas Zimmermann <tzimmermann at suse.de>

> ---
>   drivers/video/fbdev/via/lcd.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/video/fbdev/via/lcd.c b/drivers/video/fbdev/via/lcd.c
> index 4a869402d120..088b962076b5 100644
> --- a/drivers/video/fbdev/via/lcd.c
> +++ b/drivers/video/fbdev/via/lcd.c
> @@ -537,11 +537,9 @@ void viafb_lcd_set_mode(const struct fb_var_screeninfo *var, u16 cxres,
>   	u32 clock;
>   	struct via_display_timing timing;
>   	struct fb_var_screeninfo panel_var;
> -	const struct fb_videomode *mode_crt_table, *panel_crt_table;
> +	const struct fb_videomode *panel_crt_table;
>   
>   	DEBUG_MSG(KERN_INFO "viafb_lcd_set_mode!!\n");
> -	/* Get mode table */
> -	mode_crt_table = viafb_get_best_mode(set_hres, set_vres, 60);
>   	/* Get panel table Pointer */
>   	panel_crt_table = viafb_get_best_mode(panel_hres, panel_vres, 60);
>   	viafb_fill_var_timing_info(&panel_var, panel_crt_table);
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201130/91504e94/attachment.sig>