[PATCH v2 12/28] video: fbdev: tdfx: Fix set but not used warning in att_outb()

[Thomas Zimmermann]

Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
> The tmp variable were assigned but the result was never used,

s/were/was

> so delete the tmp variable.
> 
> v2:
>    - Update subject (Lee)
> 
> Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> Cc: "Gustavo A. R. Silva" <gustavoars at kernel.org>
> Cc: Sam Ravnborg <sam at ravnborg.org>
> Cc: Jani Nikula <jani.nikula at intel.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Arnd Bergmann <arnd at arndb.de>
> Cc: Lee Jones <lee.jones at linaro.org>

Acked-by: Thomas Zimmermann <tzimmermann at suse.de>

> ---
>   drivers/video/fbdev/tdfxfb.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c
> index f056d80f6359..67e37a62b07c 100644
> --- a/drivers/video/fbdev/tdfxfb.c
> +++ b/drivers/video/fbdev/tdfxfb.c
> @@ -206,9 +206,7 @@ static inline u8 crt_inb(struct tdfx_par *par, u32 idx)
>   
>   static inline void att_outb(struct tdfx_par *par, u32 idx, u8 val)
>   {
> -	unsigned char tmp;
> -
> -	tmp = vga_inb(par, IS1_R);
> +	vga_inb(par, IS1_R);

It resets the attribute register's state. Hopefully, this doesn't get 
optimized away.

>   	vga_outb(par, ATT_IW, idx);
>   	vga_outb(par, ATT_IW, val);
>   }
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201130/abdd4c62/attachment.sig>