[PATCH v2 17/28] video: fbdev: tgafb: Fix kernel-doc and set but not used warnings

[Thomas Zimmermann]

Am 28.11.20 um 23:41 schrieb Sam Ravnborg:
> Fix W=1 warnings:
> - Fix kernel-doc
> - Drop unused code
> 
> v2:
>    - Updated subject (Lee)
> 
> Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> Cc: Sam Ravnborg <sam at ravnborg.org>
> Cc: Jani Nikula <jani.nikula at intel.com>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Arnd Bergmann <arnd at arndb.de>
> Cc: Joe Perches <joe at perches.com>
> Cc: Lee Jones <lee.jones at linaro.org>

Acked-by: Thomas Zimmermann <tzimmermann at suse.de>

> ---
>   drivers/video/fbdev/tgafb.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/video/fbdev/tgafb.c b/drivers/video/fbdev/tgafb.c
> index 666fbe2f671c..ae0cf5540636 100644
> --- a/drivers/video/fbdev/tgafb.c
> +++ b/drivers/video/fbdev/tgafb.c
> @@ -555,7 +555,7 @@ tgafb_setcolreg(unsigned regno, unsigned red, unsigned green, unsigned blue,
>   
>   /**
>    *      tgafb_blank - Optional function.  Blanks the display.
> - *      @blank_mode: the blank mode we want.
> + *      @blank: the blank mode we want.
>    *      @info: frame buffer structure that represents a single frame buffer
>    */
>   static int
> @@ -837,7 +837,7 @@ tgafb_clut_imageblit(struct fb_info *info, const struct fb_image *image)
>   	u32 *palette = ((u32 *)info->pseudo_palette);
>   	unsigned long pos, line_length, i, j;
>   	const unsigned char *data;
> -	void __iomem *regs_base, *fb_base;
> +	void __iomem *fb_base;
>   
>   	dx = image->dx;
>   	dy = image->dy;
> @@ -855,7 +855,6 @@ tgafb_clut_imageblit(struct fb_info *info, const struct fb_image *image)
>   	if (dy + height > vyres)
>   		height = vyres - dy;
>   
> -	regs_base = par->tga_regs_base;
>   	fb_base = par->tga_fb_base;
>   
>   	pos = dy * line_length + (dx * 4);
> @@ -1034,7 +1033,7 @@ tgafb_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
>   		     regs_base + TGA_MODE_REG);
>   }
>   
> -/**
> +/*
>    *      tgafb_copyarea - REQUIRED function. Can use generic routines if
>    *                       non acclerated hardware and packed pixel based.
>    *                       Copies on area of the screen to another area.
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201130/60736e29/attachment.sig>