[RFC PATCH v3 1/4] RDMA/umem: Support importing dma-buf as user memory region

[Xiong, Jianxin]

> -----Original Message-----
> From: Christian König <christian.koenig at amd.com>
> Sent: Monday, October 05, 2020 3:55 AM
> To: Xiong, Jianxin <jianxin.xiong at intel.com>; linux-rdma at vger.kernel.org; dri-devel at lists.freedesktop.org
> Cc: Doug Ledford <dledford at redhat.com>; Jason Gunthorpe <jgg at ziepe.ca>; Leon Romanovsky <leon at kernel.org>; Sumit Semwal
> <sumit.semwal at linaro.org>; Vetter, Daniel <daniel.vetter at intel.com>
> Subject: Re: [RFC PATCH v3 1/4] RDMA/umem: Support importing dma-buf as user memory region
> 
> Hi Jianxin,
> 
> Am 04.10.20 um 21:12 schrieb Jianxin Xiong:
> > Dma-buf is a standard cross-driver buffer sharing mechanism that can
> > be used to support peer-to-peer access from RDMA devices.
> >
> > Device memory exported via dma-buf is associated with a file descriptor.
> > This is passed to the user space as a property associated with the
> > buffer allocation. When the buffer is registered as a memory region,
> > the file descriptor is passed to the RDMA driver along with other
> > parameters.
> >
> > Implement the common code for importing dma-buf object and mapping
> > dma-buf pages.
> >
> > Signed-off-by: Jianxin Xiong <jianxin.xiong at intel.com>
> > Reviewed-by: Sean Hefty <sean.hefty at intel.com>
> > Acked-by: Michael J. Ruhl <michael.j.ruhl at intel.com>
> 
> well first of all really nice work you have done here.
> 
> Since I'm not an expert on RDMA or its drivers I can't really review any of that part.
> 
> But at least from the DMA-buf side it looks like you are using the interface correctly as intended.
> 
> So feel free to add an Acked-by: Christian König <christian.koenig at amd.com> if it helps.
> 
> Thanks,
> Christian.

Thanks, will do.