[PATCH] drm/vkms: Unset preferred_depth

[Simon Ser]

On Tuesday, October 20, 2020 10:35 AM, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:

> There's a confusion between the preferred_depth uapi and the generic
> fbdev helpers. Former wants depth, latter wants bpp, and for XRGB8888
> they don't match. Which hit me with vkms, which wants that.
>
> All other drivers setting this and using the generic fbdev helpers use
> 16, where both numbers match, for RGB565.

Not quite: grepping reveals a majority of 24 (as shown in drmdb). A few
drivers set 16 (udl, cirrus), and hisilicon sets 32.

> Since fixing this is a bit involved (I think for atomic drivers we
> should just compute this all internally from the format list of the
> first primary plane) paper over the issue in vkms by using defaults
> everywhere. Then userspace will pick XRGB8888, and fbdev helpers will
> do the same, and we have what we want.
>
> Reported-by: Simon Ser contact at emersion.fr
> Cc: Simon Ser contact at emersion.fr
> Signed-off-by: Daniel Vetter daniel.vetter at intel.com
> Cc: Rodrigo Siqueira rodrigosiqueiramelo at gmail.com
> Cc: Melissa Wen melissa.srw at gmail.com
> Cc: Haneen Mohammed hamohammed.sa at gmail.com
> Cc: Daniel Vetter daniel at ffwll.ch

With the commit message clarified:

Reviewed-by: Simon Ser <contact at emersion.fr>