[PATCH 0/3] drm: Store USB device in struct drm_device

[Thomas Zimmermann]

Hi

On 22.10.20 11:20, Hans de Goede wrote:
> Hi,
> 
> On 10/21/20 3:07 PM, Thomas Zimmermann wrote:
>> The drivers gm12u320 and udl operate on USB devices. They leave the
>> PCI device in struct drm_device empty and store the USB device in their
>> own driver structure.
>>
>> Fix this special case and save a few bytes by putting the USB device
>> into an anonymous union with the PCI data. It's expected that DRM
>> core and helpers only touch the PCI-device field for actual PCI devices.
>>
>> Thomas Zimmermann (3):
>>   drm: Add reference to USB device to struct drm_device
>>   drm/tiny/gm12u320: Store USB device in struct drm_device.udev
>>   drm/udl: Store USB device in struct drm_device.udev
> 
> This series looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Thanks a lot. Following Daniel's request, I'll drop patch 1 and instead
do an upcast from drm_device.dev to the USB device structure. The driver
patches 2 and 3 will be slightly different. Unless you object, I''ll
take the r-b into the new patches.

Best regards
Thomas

> 
> Regards,
> 
> Hans
> 
> 
>>
>>  drivers/gpu/drm/tiny/gm12u320.c     | 52 +++++++++++++----------------
>>  drivers/gpu/drm/udl/udl_connector.c |  8 ++---
>>  drivers/gpu/drm/udl/udl_drv.c       |  2 +-
>>  drivers/gpu/drm/udl/udl_drv.h       |  1 -
>>  drivers/gpu/drm/udl/udl_main.c      | 15 +++++----
>>  include/drm/drm_device.h            | 21 ++++++++----
>>  6 files changed, 52 insertions(+), 47 deletions(-)
>>
>> --
>> 2.28.0
>>
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer