[PATCH] drm: Don't create the IN_FORMATS blob when the driver does not provide .format_mod_supported()

Simon Ser contact at emersion.fr
Fri Oct 23 22:03:50 UTC 2020


On Friday, October 23, 2020 10:39 PM, Ville Syrjala <ville.syrjala at linux.intel.com> wrote:

> From: Ville Syrjälä ville.syrjala at linux.intel.com
>
> The code responsible for creating the IN_FORMATS
> blob is broken when the driver doesn't provide a
> .format_mod_supported() hook. It just copies in
> the format list, but leaves all the modifier information
> zeroed. That would indicate (in a very silly way) that
> there are in fact no supported format+modifier combinations.
> That is utter nonsense.

Should we WARN_ON when the driver enables allow_fb_modifiers but
doesn't populate format_mod_supported?


More information about the dri-devel mailing list