[PATCH] Implement .format_mod_supported in mxsfb

Ville Syrjälä ville.syrjala at linux.intel.com
Mon Oct 26 10:52:07 UTC 2020


On Mon, Oct 26, 2020 at 10:05:17AM +0100, Daniel Vetter wrote:
> On Sun, Oct 25, 2020 at 4:52 PM Guido Günther <agx at sigxcpu.org> wrote:
> >
> > Hi Daniel,
> > On Sat, Oct 24, 2020 at 04:59:16PM +0000, Daniel Abrecht wrote:
> > > This will make sure applications which use the IN_FORMATS blob
> > > to figure out which modifiers they can use will pick up the
> > > linear modifier which is needed by mxsfb. Such applications
> > > will not work otherwise if an incompatible implicit modifier
> > > ends up being selected.
> >
> > Since this got broken by the switch away for the simple display
> > pipeline helper (ae1ed0093281939b80664a687689f12436c0e874) could
> > you add a fixes tag?
> 
> mxsfb is also missing setting the allow_fb_modifiers flag, without
> which all this modifier stuff won't work great.

drm_universal_plane_init() automagically adds it if a modifier list
is passed in.

-- 
Ville Syrjälä
Intel


More information about the dri-devel mailing list