[PATCH v10 0/6] Add support for KeemBay DRM driver
Anitha Chrisanthus
anitha.chrisanthus at intel.com
Thu Oct 29 21:27:51 UTC 2020
This is a new DRM driver for Intel's KeemBay SOC.
The SoC couples an ARM Cortex A53 CPU with an Intel
Movidius VPU.
This driver is tested with the KMB EVM board which is the refernce baord
for Keem Bay SOC. The SOC's display pipeline is as follows
+--------------+ +---------+ +-----------------------+
|LCD controller| -> |Mipi DSI | -> |Mipi to HDMI Converter |
+--------------+ +---------+ +-----------------------+
LCD controller and Mipi DSI transmitter are part of the SOC and
mipi to HDMI converter is ADV7535 for KMB EVM board.
The DRM driver is a basic KMS atomic modesetting display driver and
has no 2D or 3D graphics.It calls into the ADV bridge driver at
the connector level.
Only 1080p resolution and single plane is supported at this time.
The usecase is for debugging video and camera outputs.
Device tree patches are under review here
https://lore.kernel.org/linux-arm-kernel/20200708175020.194436-1-daniele.alessandrelli@linux.intel.com/T/
Changes since v1:
- Removed redundant license text, updated license
- Rearranged include blocks
- renamed global vars and removed extern in c
- Used upclassing for dev_private
- Used drm_dev_init in drm device create
- minor cleanups
Changes since v2:
- squashed all commits to a single commit
- logging changed to drm_info, drm_dbg etc.
- used devm_drm_dev_alloc()
- removed commented out sections and general cleanup
Changes since v3:
- renamed dev_p to kmb
- moved clocks under kmb_clock, consolidated clk initializations
- use drmm functions
- use DRM_GEM_CMA_DRIVER_OPS_VMAP
- more cleanups
Changes since v4:
- corrected spellings
Changes since v5:
- corrected checkpatch warnings/checks
-Please ignore checkpatch checks on Camelcase - this is how it is
named in the databook
- Please ignore checkpatch warnings on misspelled for hsa, dout,
widthn etc. - they are spelled as in the databook
- Please ignore checkpatch checks on macro arguments reuse -
its confirmed ok
Changes since v6:
- review changes Sam Ravnborg and Thomas Zimmerman
split patch into 4 parts, part1 register definitions, part2 display
driver files, part3 mipi dsi, part4 build files (Sam)
removed kmb_crtc.h kmb_crtc_cleanup (Thomas)
renamed mode_set, kmb_load, inlined unload (Thomas)
moved remaining logging to drm_*(Thomas)
re-orged driver initialization (Thomas)
moved plane_status to drm_private (Sam)
removed unnecessary logs and defines and ifdef codes (Sam)
split dphy_init_sequence smaller (Sam)
removed redundant checks in kmb_dsi (Sam)
changed kmb_dsi_init to drm_bridge_connector_init and
drm_connector_attach_encoder to bridge's connector (Sam)
call helper_check in plane_atomic_check (Sam)
renamed set to get for bpp and format functions(Sam)
use drm helper functions for reset, duplicate/destroy state instead
of kmb functions (Sam)
removed kmb_priv from kmb_plane and removed kmb_plane_state (Sam)
Changes since v7:
- tested with 5.9 kernel and made the following changes
get clk_pll0 from display node in dt
call drm_bridge_attach with DRM_BRIDGE_ATTACH_NO_CONNECTOR
Also added Maintainer entry
Changes since v8:
DT review changes (Rob)
renamed kmb_dsi_hw_init to kmb_dsi_mode_set (Daniel V)
moved csc_coef_lcd to plane.c (Daniel Vetter)
call drm_atomic_helper_shutdown in remove (Daniel V)
use drm_crtc_handle_vblank (Daniel V)
renamed kmb_dsi_hw_init to kmb_dsi_mode_set (Daniel V)
complimentary changes to device tree changes (Rob)
removed redundant definitions in kmb_dsi.h
Changes since v9:
Review changes from Sam Ravnborg which are:
DT is separated to display and Mipi DSI as per Sam suggestion and the
driver has changes to reflect this separation. Also most of the
MIPI DSI code is isolated and separated from the main driver, worked
closely with Sam on these changes. This split is to ease review and
driver is only buildable after the last patch (build files).
call drm_crtc_arm_vblank_event in atomic_flush (Daniel V)
moved global vars to kmb_private and added locks (Daniel V)
added comments to clarify empty dsi host functions (Daniel V)
Anitha Chrisanthus (6):
dt-bindings: display: Add support for Intel KeemBay Display
dt-bindings: display: bridge: Intel KeemBay DSI
drm/kmb: Keem Bay driver register definition
drm/kmb: Add support for KeemBay Display
drm/kmb: Mipi DSI part of the display driver
drm/kmb: Build files for KeemBay Display driver
.../bindings/display/bridge/intel,keembay-dsi.yaml | 101 ++
.../bindings/display/intel,keembay-display.yaml | 75 +
MAINTAINERS | 7 +
drivers/gpu/drm/Kconfig | 2 +
drivers/gpu/drm/Makefile | 1 +
drivers/gpu/drm/kmb/Kconfig | 12 +
drivers/gpu/drm/kmb/Makefile | 2 +
drivers/gpu/drm/kmb/kmb_crtc.c | 232 +++
drivers/gpu/drm/kmb/kmb_drv.c | 603 ++++++++
drivers/gpu/drm/kmb/kmb_drv.h | 109 ++
drivers/gpu/drm/kmb/kmb_dsi.c | 1540 ++++++++++++++++++++
drivers/gpu/drm/kmb/kmb_dsi.h | 387 +++++
drivers/gpu/drm/kmb/kmb_plane.c | 490 +++++++
drivers/gpu/drm/kmb/kmb_plane.h | 99 ++
drivers/gpu/drm/kmb/kmb_regs.h | 725 +++++++++
15 files changed, 4385 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/bridge/intel,keembay-dsi.yaml
create mode 100644 Documentation/devicetree/bindings/display/intel,keembay-display.yaml
create mode 100644 drivers/gpu/drm/kmb/Kconfig
create mode 100644 drivers/gpu/drm/kmb/Makefile
create mode 100644 drivers/gpu/drm/kmb/kmb_crtc.c
create mode 100644 drivers/gpu/drm/kmb/kmb_drv.c
create mode 100644 drivers/gpu/drm/kmb/kmb_drv.h
create mode 100644 drivers/gpu/drm/kmb/kmb_dsi.c
create mode 100644 drivers/gpu/drm/kmb/kmb_dsi.h
create mode 100644 drivers/gpu/drm/kmb/kmb_plane.c
create mode 100644 drivers/gpu/drm/kmb/kmb_plane.h
create mode 100644 drivers/gpu/drm/kmb/kmb_regs.h
--
2.7.4
More information about the dri-devel
mailing list