[PATCH v10 2/6] dt-bindings: display: bridge: Intel KeemBay DSI

[Neil Armstrong]

On 29/10/2020 23:22, Sam Ravnborg wrote:
> Hi Anitha.
> 
> On Thu, Oct 29, 2020 at 02:27:53PM -0700, Anitha Chrisanthus wrote:
>> This patch adds bindings for Intel KeemBay MIPI DSI
>>
>> Signed-off-by: Anitha Chrisanthus <anitha.chrisanthus at intel.com>
>> Cc: Sam Ravnborg <sam at ravnborg.org>
>> Cc: Thomas Zimmermann <tzimmermann at suse.de>
>> Cc: Daniel Vetter <daniel at ffwll.ch>
> 
> This again matches my understanding of the HW - good.
> 
> One small nit below, with that addressed:
> Reviewed-by: Sam Ravnborg <sam at ravnborg.org>

Same, this one is good, Thanks.

Reviewed-by: Neil Armstrong <narmstrong at baylibre.com>


> 
>> ---
>>  .../bindings/display/bridge/intel,keembay-dsi.yaml | 101 +++++++++++++++++++++
>>  1 file changed, 101 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/display/bridge/intel,keembay-dsi.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/intel,keembay-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/intel,keembay-dsi.yaml
>> new file mode 100644
>> index 0000000..4cef64e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/bridge/intel,keembay-dsi.yaml
>> @@ -0,0 +1,101 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/bridge/intel,keembay-dsi.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Devicetree bindings for Intel Keem Bay mipi dsi controller
>> +
>> +maintainers:
>> +  - Anitha Chrisanthus <anitha.chrisanthus at intel.com>
>> +  - Edmond J Dea <edmund.j.dea at intel.com>
>> +
>> +properties:
>> +  compatible:
>> +    const: intel,keembay-dsi
>> +
>> +  reg:
>> +    items:
>> +      - description: MIPI registers range
>> +
>> +  reg-names:
>> +    items:
>> +      - const: mipi
>> +
>> +  clocks:
>> +    items:
>> +      - description: MIPI DSI clock
>> +      - description: MIPI DSI econfig clock
>> +      - description: MIPI DSI config clock
>> +
>> +  clock-names:
>> +    items:
>> +      - const: clk_mipi
>> +      - const: clk_mipi_ecfg
>> +      - const: clk_mipi_cfg
>> +
>> +  ports:
>> +    type: object
>> +
>> +    properties:
>> +      '#address-cells':
>> +       const: 1
>> +
>> +      '#size-cells':
>> +       const: 0
>> +
>> +      port at 0:
>> +        type: object
>> +        description: MIPI DSI input port.
>> +
>> +      port at 1:
>> +        type: object
>> +        description: DSI output port to adv7535.
> Drop the mention of adv7535 - the DT decide what the port is connected
> to.
> 
>> +
>> +    required:
>> +      - port at 0
>> +      - port at 1
>> +
>> +    additionalProperties: false
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - reg-names
>> +  - clocks
>> +  - clock-names
>> +  - ports
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    mipi-dsi at 20900000 {
>> +        compatible = "intel,keembay-dsi";
>> +        reg = <0x20900000 0x4000>;
>> +        reg-names = "mipi";
>> +        clocks = <&scmi_clk 0x86>,
>> +                 <&scmi_clk 0x88>,
>> +                 <&scmi_clk 0x89>;
>> +        clock-names = "clk_mipi", "clk_mipi_ecfg",
>> +                      "clk_mipi_cfg";
>> +
>> +        ports {
>> +            #address-cells = <1>;
>> +            #size-cells = <0>;
>> +
>> +            port at 0 {
>> +                reg = <0>;
>> +                dsi_in: endpoint {
>> +                    remote-endpoint = <&disp_out>;
>> +                };
>> +            };
>> +
>> +            port at 1 {
>> +                reg = <1>;
>> +                dsi_out: endpoint {
>> +                    remote-endpoint = <&adv7535_input>;
>> +                };
>> +            };
>> +        };
>> +    };
>> -- 
>> 2.7.4
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>