[PATCH 3/3] drm/amdgpu: Remove superfluous NULL check
Daniel Vetter
daniel at ffwll.ch
Wed Sep 2 06:59:05 UTC 2020
On Tue, Sep 01, 2020 at 09:06:45PM -0400, Luben Tuikov wrote:
> The DRM device is a static member of
> the amdgpu device structure and as such
> always exists, so long as the PCI and
> thus the amdgpu device exist.
>
> Signed-off-by: Luben Tuikov <luben.tuikov at amd.com>
On this patch, but not the other two earlier in this series:
Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index c4900471beb0..6dcc256b9ebc 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3471,9 +3471,6 @@ int amdgpu_device_suspend(struct drm_device *dev, bool fbcon)
> struct drm_connector_list_iter iter;
> int r;
>
> - if (!dev)
> - return -ENODEV;
> -
> adev = drm_to_adev(dev);
>
> if (dev->switch_power_state == DRM_SWITCH_POWER_OFF)
> --
> 2.28.0.394.ge197136389
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
More information about the dri-devel
mailing list