[PATCH 1/3] drm/ttm: make sure that we always zero init mem.bus v2

Ben Skeggs skeggsb at gmail.com
Thu Sep 3 04:30:24 UTC 2020


On Wed, 2 Sep 2020 at 01:05, Christian König
<ckoenig.leichtzumerken at gmail.com> wrote:
>
> We are trying to remove the io_lru handling and depend
> on zero init base, offset and addr here.
>
> v2: init addr as well
Looks like the issues I noticed in the previous version have been
dealt with, so, for the series:

Reviewed-by: Ben Skeggs <bskeggs at redhat.com>

>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/ttm/ttm_bo.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index e3931e515906..772c640a6046 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -650,6 +650,9 @@ static int ttm_bo_evict(struct ttm_buffer_object *bo,
>         evict_mem.mm_node = NULL;
>         evict_mem.bus.io_reserved_vm = false;
>         evict_mem.bus.io_reserved_count = 0;
> +       evict_mem.bus.base = 0;
> +       evict_mem.bus.offset = 0;
> +       evict_mem.bus.addr = NULL;
>
>         ret = ttm_bo_mem_space(bo, &placement, &evict_mem, ctx);
>         if (ret) {
> @@ -1084,6 +1087,9 @@ static int ttm_bo_move_buffer(struct ttm_buffer_object *bo,
>         mem.page_alignment = bo->mem.page_alignment;
>         mem.bus.io_reserved_vm = false;
>         mem.bus.io_reserved_count = 0;
> +       mem.bus.base = 0;
> +       mem.bus.offset = 0;
> +       mem.bus.addr = NULL;
>         mem.mm_node = NULL;
>
>         /*
> @@ -1243,6 +1249,9 @@ int ttm_bo_init_reserved(struct ttm_bo_device *bdev,
>         bo->mem.page_alignment = page_alignment;
>         bo->mem.bus.io_reserved_vm = false;
>         bo->mem.bus.io_reserved_count = 0;
> +       bo->mem.bus.base = 0;
> +       bo->mem.bus.offset = 0;
> +       bo->mem.bus.addr = NULL;
>         bo->moving = NULL;
>         bo->mem.placement = (TTM_PL_FLAG_SYSTEM | TTM_PL_FLAG_CACHED);
>         bo->acc_size = acc_size;
> --
> 2.17.1
>


More information about the dri-devel mailing list