[RFC PATCH v2 15/17] drm/tegra: Add power_on/power_off engine callbacks

Mikko Perttunen cyndis at kapsi.fi
Wed Sep 9 08:11:22 UTC 2020


On 9/9/20 3:16 AM, Dmitry Osipenko wrote:
> 05.09.2020 13:34, Mikko Perttunen пишет:
> ...
>> +static int vic_power_on(struct tegra_drm_client *client)
>> +{
>> +	struct vic *vic = to_vic(client);
>> +
>> +	return pm_runtime_get_sync(vic->dev);
> 
> Please keep in mind that RPM needs to be put in a case of error.
> 
> Maybe it would be better if driver-core could take care of
> resuming/suspending client's RPM instead of putting that burden on each
> client individually?
> 

Good point, we should be able to just make RPM calls from the core code. 
I'll change it so (and fix the refcounting).

Mikko


More information about the dri-devel mailing list