[PATCH] drm/imx/dcss: fix compilation issue on 32bit

[Daniel Vetter]

On Thu, Sep 10, 2020 at 11:53 AM Laurentiu Palcu
<laurentiu.palcu at oss.nxp.com> wrote:
>
> When compiling for 32bit platforms, the compilation fails with:
>
> ERROR: modpost: "__aeabi_ldivmod"
> [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> ERROR: modpost: "__aeabi_uldivmod"
> [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
>
> This patch adds a dependency on ARM64 since no 32bit SoCs have DCSS, so far.

Usual way to fix this correctly is using the right division macros,
not limiting the driver to 64bit. But this works for now, would be
good to fix this properly for compile-testing and all that.

> Signed-off-by: Laurentiu Palcu <laurentiu.palcu at oss.nxp.com>
> Reported-by: Daniel Vetter <daniel at ffwll.ch>

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Please push to drm-misc-next.
-Daniel



---
>  drivers/gpu/drm/imx/dcss/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig
> index 69860de8861f..2b17a964ff05 100644
> --- a/drivers/gpu/drm/imx/dcss/Kconfig
> +++ b/drivers/gpu/drm/imx/dcss/Kconfig
> @@ -3,7 +3,7 @@ config DRM_IMX_DCSS
>         select IMX_IRQSTEER
>         select DRM_KMS_CMA_HELPER
>         select VIDEOMODE_HELPERS
> -       depends on DRM && ARCH_MXC
> +       depends on DRM && ARCH_MXC && ARM64
>         help
>           Choose this if you have a NXP i.MX8MQ based system and want to use the
>           Display Controller Subsystem. This option enables DCSS support.
> --
> 2.17.1
>


-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch