[PATCH] drm/panel: st7703: Make jh057n00900_panel_desc static

Guido Günther agx at sigxcpu.org
Sun Sep 13 12:00:14 UTC 2020


Hi,
On Sat, Sep 12, 2020 at 11:38:09AM +0800, Jason Yan wrote:
> This eliminates the following sparse warning:
> 
> drivers/gpu/drm/panel/panel-sitronix-st7703.c:156:26: warning: symbol
> 'jh057n00900_panel_desc' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: Jason Yan <yanaijie at huawei.com>
> ---
>  drivers/gpu/drm/panel/panel-sitronix-st7703.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> index c22e7c49e077..7c07a8fc8506 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> @@ -153,7 +153,7 @@ static const struct drm_display_mode jh057n00900_mode = {
>  	.height_mm   = 130,
>  };
>  
> -struct st7703_panel_desc jh057n00900_panel_desc = {
> +static struct st7703_panel_desc jh057n00900_panel_desc = {

Can we even make it `static const`? With that

Reviewed-by: Guido Günther <agx at sigxcpu.org>

Cheers,
 -- Guido

>  	.mode = &jh057n00900_mode,
>  	.lanes = 4,
>  	.mode_flags = MIPI_DSI_MODE_VIDEO |
> -- 
> 2.25.4
> 


More information about the dri-devel mailing list