[PATCH -next] dma-buf: heaps: Remove unused variable ret

Sumit Semwal sumit.semwal at linaro.org
Tue Sep 22 14:51:42 UTC 2020


Hello Zou,

On Tue, 22 Sep 2020 at 18:12, Christian König <christian.koenig at amd.com> wrote:
>
> Am 22.09.20 um 09:53 schrieb Zou Wei:
> > This patch fixes below warnings reported by coccicheck
> >
> > ./drivers/dma-buf/heaps/heap-helpers.c:202:5-8: Unneeded variable: "ret". Return "0" on line 215
> >
> > Signed-off-by: Zou Wei <zou_wei at huawei.com>
>
> Acked-by: Christian König <christian.koenig at amd.com>
>
> Going to pick this up for drm-misc-next.
Thanks Christian!
Fwiw, feel free to add my
Acked-by: Sumit Semwal <sumit.semwal at linaro.org>
>
> > ---
> >   drivers/dma-buf/heaps/heap-helpers.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/dma-buf/heaps/heap-helpers.c b/drivers/dma-buf/heaps/heap-helpers.c
> > index d0696cf..7969510 100644
> > --- a/drivers/dma-buf/heaps/heap-helpers.c
> > +++ b/drivers/dma-buf/heaps/heap-helpers.c
> > @@ -199,7 +199,6 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf,
> >   {
> >       struct heap_helper_buffer *buffer = dmabuf->priv;
> >       struct dma_heaps_attachment *a;
> > -     int ret = 0;
> >
> >       mutex_lock(&buffer->lock);
> >
> > @@ -212,7 +211,7 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf,
> >       }
> >       mutex_unlock(&buffer->lock);
> >
> > -     return ret;
> > +     return 0;
> >   }
> >
> >   static int dma_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf,
>

Best,
Sumit.


More information about the dri-devel mailing list