[PATCH] drm/hisilicon: Deleted the drm_device declaration

Thomas Zimmermann tzimmermann at suse.de
Fri Sep 25 07:02:31 UTC 2020


Hi,

just a few nits.

Am 25.09.20 um 08:49 schrieb Tian Tao:
> drm_framebuffer.h contains drm/drm_device.h and struct drm_device is

contains -> includes

> already declared in this file, so there is no need to declare struct

declared -> defined

> drm_device in hibm_drm_drv.h.
> 
> Signed-off-by: Tian Tao <tiantao6 at hisilicon.com>

Acked-by: Thomas Zimmermann <tzimmermann at suse.de>

> ---
>  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
> index 87d2aad..6a63502 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
> @@ -22,8 +22,6 @@
>  #include <drm/drm_fb_helper.h>
>  #include <drm/drm_framebuffer.h>
>  
> -struct drm_device;
> -
>  struct hibmc_connector {
>  	struct drm_connector base;
>  
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 516 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200925/4da18f92/attachment.sig>


More information about the dri-devel mailing list