[PATCH 1/6] drm/atomic: Pass the full state to CRTC atomic enable/disable
kernel test robot
lkp at intel.com
Fri Sep 25 13:37:32 UTC 2020
Hi Maxime,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[cannot apply to shawnguo/for-next drm-intel/for-linux-next linus/master anholt/for-next v5.9-rc6 next-20200925]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Maxime-Ripard/drm-vc4-hdmi-Support-the-10-12-bit-output/20200925-151211
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/1ceb933c2a3dd89451b7563e66097d05e1df8d2e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Maxime-Ripard/drm-vc4-hdmi-Support-the-10-12-bit-output/20200925-151211
git checkout 1ceb933c2a3dd89451b7563e66097d05e1df8d2e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
All error/warnings (new ones prefixed by >>):
drivers/gpu/drm/imx/dcss/dcss-crtc.c: In function 'dcss_crtc_atomic_enable':
>> drivers/gpu/drm/imx/dcss/dcss-crtc.c:82:42: error: implicit declaration of function 'drm_atomic_get_old_crtc_state' [-Werror=implicit-function-declaration]
82 | struct drm_crtc_state *old_crtc_state = drm_atomic_get_old_crtc_state(state,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/imx/dcss/dcss-crtc.c:82:42: warning: initialization of 'struct drm_crtc_state *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
drivers/gpu/drm/imx/dcss/dcss-crtc.c: In function 'dcss_crtc_atomic_disable':
drivers/gpu/drm/imx/dcss/dcss-crtc.c:118:42: warning: initialization of 'struct drm_crtc_state *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
118 | struct drm_crtc_state *old_crtc_state = drm_atomic_get_old_crtc_state(state,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/drm_atomic_get_old_crtc_state +82 drivers/gpu/drm/imx/dcss/dcss-crtc.c
78
79 static void dcss_crtc_atomic_enable(struct drm_crtc *crtc,
80 struct drm_atomic_state *state)
81 {
> 82 struct drm_crtc_state *old_crtc_state = drm_atomic_get_old_crtc_state(state,
83 crtc);
84 struct dcss_crtc *dcss_crtc = container_of(crtc, struct dcss_crtc,
85 base);
86 struct dcss_dev *dcss = dcss_crtc->base.dev->dev_private;
87 struct drm_display_mode *mode = &crtc->state->adjusted_mode;
88 struct drm_display_mode *old_mode = &old_crtc_state->adjusted_mode;
89 struct videomode vm;
90
91 drm_display_mode_to_videomode(mode, &vm);
92
93 pm_runtime_get_sync(dcss->dev);
94
95 vm.pixelclock = mode->crtc_clock * 1000;
96
97 dcss_ss_subsam_set(dcss->ss);
98 dcss_dtg_css_set(dcss->dtg);
99
100 if (!drm_mode_equal(mode, old_mode) || !old_crtc_state->active) {
101 dcss_dtg_sync_set(dcss->dtg, &vm);
102 dcss_ss_sync_set(dcss->ss, &vm,
103 mode->flags & DRM_MODE_FLAG_PHSYNC,
104 mode->flags & DRM_MODE_FLAG_PVSYNC);
105 }
106
107 dcss_enable_dtg_and_ss(dcss);
108
109 dcss_ctxld_enable(dcss->ctxld);
110
111 /* Allow CTXLD kick interrupt to be disabled when VBLANK is disabled. */
112 dcss_crtc->disable_ctxld_kick_irq = true;
113 }
114
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 74216 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200925/d4848ea0/attachment-0001.gz>
More information about the dri-devel
mailing list