[PATCH] drm/panel: Convert sysfs sprintf/snprintf family to sysfs_emit

Daniel Vetter daniel at ffwll.ch
Thu Apr 8 10:51:41 UTC 2021


On Tue, Mar 30, 2021 at 09:54:48AM +0800, Tian Tao wrote:
> Fix the following coccicheck warning:
> drivers/gpu/drm/panel//panel-tpo-td043mtea1.c:217:8-16: WARNING:
> use scnprintf or sprintf
> drivers/gpu/drm/panel//panel-tpo-td043mtea1.c:189:8-16: WARNING:
> use scnprintf or sprintf
> 
> Signed-off-by: Tian Tao <tiantao6 at hisilicon.com>

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

> ---
>  drivers/gpu/drm/panel/panel-tpo-td043mtea1.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
> index 49e6c93..bacaf1b 100644
> --- a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
> +++ b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
> @@ -186,7 +186,7 @@ static ssize_t vmirror_show(struct device *dev, struct device_attribute *attr,
>  {
>  	struct td043mtea1_panel *lcd = dev_get_drvdata(dev);
>  
> -	return snprintf(buf, PAGE_SIZE, "%d\n", lcd->vmirror);
> +	return sysfs_emit(buf, "%d\n", lcd->vmirror);
>  }
>  
>  static ssize_t vmirror_store(struct device *dev, struct device_attribute *attr,
> @@ -214,7 +214,7 @@ static ssize_t mode_show(struct device *dev, struct device_attribute *attr,
>  {
>  	struct td043mtea1_panel *lcd = dev_get_drvdata(dev);
>  
> -	return snprintf(buf, PAGE_SIZE, "%d\n", lcd->mode);
> +	return sysfs_emit(buf, "%d\n", lcd->mode);
>  }
>  
>  static ssize_t mode_store(struct device *dev, struct device_attribute *attr,
> -- 
> 2.7.4
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list