[PATCH -next] drm/amd/display: Fix the Wunused-function warning

Harry Wentland harry.wentland at amd.com
Thu Apr 8 15:09:31 UTC 2021


On 2021-04-08 8:41 a.m., Shaokun Zhang wrote:
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:941:13: warning: ‘dm_dmub_trace_high_irq’ defined but not used [-Wunused-function]
>    941 | static void dm_dmub_trace_high_irq(void *interrupt_params)
>        |             ^~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 83b39e1fc3ea ("drm/amd/display: Log DMCUB trace buffer events")
> Cc: Leo (Hanghong) Ma <hanghong.ma at amd.com>
> Cc: Daniel Wheeler <daniel.wheeler at amd.com>
> Cc: Harry Wentland <Harry.Wentland at amd.com>
> Cc: Solomon Chiu <solomon.chiu at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun at hisilicon.com>

Reviewed-by: Harry Wentland <harry.wentland at amd.com>

Harry

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index daacc5cc8d51..5298e5d4075b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -937,6 +937,7 @@ static int dm_dmub_hw_init(struct amdgpu_device *adev)
>   	return 0;
>   }
>   
> +#if defined(CONFIG_DRM_AMD_DC_DCN)
>   #define DMUB_TRACE_MAX_READ 64
>   static void dm_dmub_trace_high_irq(void *interrupt_params)
>   {
> @@ -963,7 +964,6 @@ static void dm_dmub_trace_high_irq(void *interrupt_params)
>   	ASSERT(count <= DMUB_TRACE_MAX_READ);
>   }
>   
> -#if defined(CONFIG_DRM_AMD_DC_DCN)
>   static void mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_addr_space_config *pa_config)
>   {
>   	uint64_t pt_base;
> 



More information about the dri-devel mailing list