[Outreachy kernel] [PATCH Resend] drm/drm_bufs.c: In switch, add break in default case

[Fabio M. De Francesco]

On Saturday, April 17, 2021 5:45:46 PM CEST Julia Lawall wrote:
> On Sat, 17 Apr 2021, Fabio M. De Francesco wrote:
> > Added a 'break' in the default case of a switch selection statement.
> 
> Why?
>
GCC issues a warning, even if it is not strictly necessary for the code to 
work properly. Do you think that I have to explain in the patch log the reason 
why I made that change?

Thanks,

Fabio
>
> julia
> 
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco at gmail.com>
> > ---
> > 
> >  drivers/gpu/drm/drm_bufs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
> > index e3d77dfefb0a..fc40aa0adf73 100644
> > --- a/drivers/gpu/drm/drm_bufs.c
> > +++ b/drivers/gpu/drm/drm_bufs.c
> > @@ -79,7 +79,7 @@ static struct drm_map_list *drm_find_matching_map(struct
> > drm_device *dev,> 
> >  				return entry;
> >  			
> >  			break;
> >  		
> >  		default: /* Make gcc happy */
> > 
> > -			;
> > +			break;
> > 
> >  		}
> >  		if (entry->map->offset == map->offset)
> >  		
> >  			return entry;
> > 
> > --
> > 2.31.1
> > 
> > --
> > You received this message because you are subscribed to the Google Groups
> > "outreachy-kernel" group. To unsubscribe from this group and stop 
receiving
> > emails from it, send an email to
> > outreachy-kernel+unsubscribe at googlegroups.com. To view this discussion on
> > the web visit
> > https://groups.google.com/d/msgid/outreachy-kernel/20210417153540.22017-1-f
> > mdefrancesco%40gmail.com.