[PATCH] drm/i915/gem: Remove reference to struct drm_device.pdev

Thomas Zimmermann tzimmermann at suse.de
Tue Apr 27 17:46:03 UTC 2021



Am 27.04.21 um 16:39 schrieb Ruhl, Michael J:
> 
>> -----Original Message-----
>> From: dri-devel <dri-devel-bounces at lists.freedesktop.org> On Behalf Of
>> Thomas Zimmermann
>> Sent: Tuesday, April 27, 2021 7:08 AM
>> To: jani.nikula at linux.intel.com; joonas.lahtinen at linux.intel.com; Vivi, Rodrigo
>> <rodrigo.vivi at intel.com>; airlied at linux.ie; daniel at ffwll.ch; Auld, Matthew
>> <matthew.auld at intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>; Ursulin, Tvrtko
>> <tvrtko.ursulin at intel.com>; Mika Kuoppala
>> <mika.kuoppala at linux.intel.com>; intel-gfx at lists.freedesktop.org; Gustavo
>> A. R. Silva <gustavoars at kernel.org>; dri-devel at lists.freedesktop.org; Chris
>> Wilson <chris at chris-wilson.co.uk>; Tang, CQ <cq.tang at intel.com>; Hellstrom,
>> Thomas <thomas.hellstrom at intel.com>; Thomas Zimmermann
>> <tzimmermann at suse.de>; Daniel Vetter <daniel.vetter at ffwll.ch>; Liu,
>> Xinyun <xinyun.liu at intel.com>; Dan Carpenter <dan.carpenter at oracle.com>
>> Subject: [PATCH] drm/i915/gem: Remove reference to struct
>> drm_device.pdev
>>
>> References to struct drm_device.pdev should be used any longer as
> 
> should not be used
>               ^^^
> ?

Oh, indeed.

> 
> m
> 
>> the field will be moved into the struct's legacy section. Add a fix
>> for the rsp commit.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
>> Fixes: d57d4a1daf5e ("drm/i915: Create stolen memory region from local
>> memory")
>> Cc: CQ Tang <cq.tang at intel.com>
>> Cc: Matthew Auld <matthew.auld at intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
>> Cc: Xinyun Liu <xinyun.liu at intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> Cc: Jani Nikula <jani.nikula at linux.intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
>> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
>> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>> Cc: "Thomas Hellström" <thomas.hellstrom at intel.com>
>> Cc: "Gustavo A. R. Silva" <gustavoars at kernel.org>
>> Cc: Dan Carpenter <dan.carpenter at oracle.com>
>> Cc: intel-gfx at lists.freedesktop.org
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>> b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>> index c5b64b2400e8..e1a32672bbe8 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>> @@ -773,7 +773,7 @@ struct intel_memory_region *
>> i915_gem_stolen_lmem_setup(struct drm_i915_private *i915)
>> {
>> 	struct intel_uncore *uncore = &i915->uncore;
>> -	struct pci_dev *pdev = i915->drm.pdev;
>> +	struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
>> 	struct intel_memory_region *mem;
>> 	resource_size_t io_start;
>> 	resource_size_t lmem_size;
>> --
>> 2.31.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20210427/251918d8/attachment.sig>


More information about the dri-devel mailing list