[PATCH v2] drm/i915/gem: Remove reference to struct drm_device.pdev

Jani Nikula jani.nikula at linux.intel.com
Thu Apr 29 09:32:37 UTC 2021


On Tue, 27 Apr 2021, "Ruhl, Michael J" <michael.j.ruhl at intel.com> wrote:
>>-----Original Message-----
>>From: Thomas Zimmermann <tzimmermann at suse.de>
>>Sent: Tuesday, April 27, 2021 1:49 PM
>>To: jani.nikula at linux.intel.com; joonas.lahtinen at linux.intel.com; Vivi, Rodrigo
>><rodrigo.vivi at intel.com>; airlied at linux.ie; daniel at ffwll.ch; Auld, Matthew
>><matthew.auld at intel.com>; Ruhl, Michael J <michael.j.ruhl at intel.com>
>>Cc: intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org; Thomas
>>Zimmermann <tzimmermann at suse.de>; Nikula, Jani
>><jani.nikula at intel.com>; Tang, CQ <cq.tang at intel.com>; Tvrtko Ursulin
>><tvrtko.ursulin at linux.intel.com>; Liu, Xinyun <xinyun.liu at intel.com>; Ursulin,
>>Tvrtko <tvrtko.ursulin at intel.com>; Chris Wilson <chris at chris-wilson.co.uk>;
>>Mika Kuoppala <mika.kuoppala at linux.intel.com>; Daniel Vetter
>><daniel.vetter at ffwll.ch>; Maarten Lankhorst
>><maarten.lankhorst at linux.intel.com>; Hellstrom, Thomas
>><thomas.hellstrom at intel.com>; Gustavo A. R. Silva
>><gustavoars at kernel.org>; Dan Carpenter <dan.carpenter at oracle.com>
>>Subject: [PATCH v2] drm/i915/gem: Remove reference to struct
>>drm_device.pdev
>>
>>References to struct drm_device.pdev should not be used any longer as
>>the field will be moved into the struct's legacy section. Add a fix
>>for the rsp commit.
>
> Commit message match the patch.
>
> Reviewed-by: Michael J. Ruhl <michael.j.ruhl at intel.com

Thanks for the patch and review, pushed to drm-intel-gt-next.

BR,
Jani.

>
> M
>
>>v2:
>>	* fix an error in the commit description (Michael)
>>
>>Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
>>Reviewed-by: Jani Nikula <jani.nikula at intel.com>
>>Fixes: d57d4a1daf5e ("drm/i915: Create stolen memory region from local
>>memory")
>>Cc: CQ Tang <cq.tang at intel.com>
>>Cc: Matthew Auld <matthew.auld at intel.com>
>>Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
>>Cc: Xinyun Liu <xinyun.liu at intel.com>
>>Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>Cc: Jani Nikula <jani.nikula at linux.intel.com>
>>Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>>Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>>Cc: Chris Wilson <chris at chris-wilson.co.uk>
>>Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
>>Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
>>Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>>Cc: "Thomas Hellström" <thomas.hellstrom at intel.com>
>>Cc: "Gustavo A. R. Silva" <gustavoars at kernel.org>
>>Cc: Dan Carpenter <dan.carpenter at oracle.com>
>>Cc: intel-gfx at lists.freedesktop.org
>>---
>> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>>b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>>index c5b64b2400e8..e1a32672bbe8 100644
>>--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>>+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
>>@@ -773,7 +773,7 @@ struct intel_memory_region *
>> i915_gem_stolen_lmem_setup(struct drm_i915_private *i915)
>> {
>> 	struct intel_uncore *uncore = &i915->uncore;
>>-	struct pci_dev *pdev = i915->drm.pdev;
>>+	struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
>> 	struct intel_memory_region *mem;
>> 	resource_size_t io_start;
>> 	resource_size_t lmem_size;
>>--
>>2.31.1
>

-- 
Jani Nikula, Intel Open Source Graphics Center


More information about the dri-devel mailing list