[PATCH] drm/radeon: Update pitch for page flip

[Christian König]

Am 02.08.21 um 09:43 schrieb Zhenneng Li:
> When primary bo is updated, crtc's pitch may
> have not been updated, this will lead to show
> disorder content when user changes display mode,
> we update crtc's pitch in page flip to avoid
> this bug.
> This refers to amdgpu's pageflip.

Alex is the expert to ask about that code, but I'm not sure if that is 
really correct for the old hardware.

As far as I know the crtc's pitch should not change during a page flip, 
but only during a full mode set.

So could you elaborate a bit more how you trigger this?

Thanks,
Christian.

>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: "Christian König" <christian.koenig at amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan at amd.com>
> Cc: David Airlie <airlied at linux.ie>
> Cc: Daniel Vetter <daniel at ffwll.ch>
> Cc: amd-gfx at lists.freedesktop.org
> Cc: dri-devel at lists.freedesktop.org
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Zhenneng Li <lizhenneng at kylinos.cn>
> ---
>   drivers/gpu/drm/radeon/evergreen.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/evergreen.c b/drivers/gpu/drm/radeon/evergreen.c
> index 36a888e1b179..eeb590d2dec2 100644
> --- a/drivers/gpu/drm/radeon/evergreen.c
> +++ b/drivers/gpu/drm/radeon/evergreen.c
> @@ -28,6 +28,7 @@
>   
>   #include <drm/drm_vblank.h>
>   #include <drm/radeon_drm.h>
> +#include <drm/drm_fourcc.h>
>   
>   #include "atom.h"
>   #include "avivod.h"
> @@ -1414,10 +1415,15 @@ void evergreen_page_flip(struct radeon_device *rdev, int crtc_id, u64 crtc_base,
>   			 bool async)
>   {
>   	struct radeon_crtc *radeon_crtc = rdev->mode_info.crtcs[crtc_id];
> +	struct drm_framebuffer *fb = radeon_crtc->base.primary->fb;
>   
> -	/* update the scanout addresses */
> +	/* flip at hsync for async, default is vsync */
>   	WREG32(EVERGREEN_GRPH_FLIP_CONTROL + radeon_crtc->crtc_offset,
>   	       async ? EVERGREEN_GRPH_SURFACE_UPDATE_H_RETRACE_EN : 0);
> +	/* update pitch */
> +	WREG32(EVERGREEN_GRPH_PITCH + radeon_crtc->crtc_offset,
> +	       fb->pitches[0] / fb->format->cpp[0]);
> +	/* update the scanout addresses */
>   	WREG32(EVERGREEN_GRPH_PRIMARY_SURFACE_ADDRESS_HIGH + radeon_crtc->crtc_offset,
>   	       upper_32_bits(crtc_base));
>   	WREG32(EVERGREEN_GRPH_PRIMARY_SURFACE_ADDRESS + radeon_crtc->crtc_offset,
>
> No virus found
> 		Checked by Hillstone Network AntiVirus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20210802/cd32498f/attachment-0001.htm>