[PATCH 02/14] drm/kmb: Define driver date and major/minor version

[Chrisanthus, Anitha]

Thanks Thomas, I'll keep this in mind for the next patch.

> -----Original Message-----
> From: dri-devel <dri-devel-bounces at lists.freedesktop.org> On Behalf Of
> Thomas Zimmermann
> Sent: Wednesday, August 4, 2021 11:13 AM
> To: Chrisanthus, Anitha <anitha.chrisanthus at intel.com>; dri-
> devel at lists.freedesktop.org; Dea, Edmund J <edmund.j.dea at intel.com>
> Subject: Re: [PATCH 02/14] drm/kmb: Define driver date and major/minor
> version
> 
> Hi,
> 
> just a friendly reminder that branches that end with -fixes are for
> fixes that are required in upstream ASAP. I found this patch in
> drm-misc-fixes. It's not important, so it should have gone into
> drm-misc-next instead.
> 
> Best regards
> Thomas
> 
> Am 28.07.21 um 02:31 schrieb Anitha Chrisanthus:
> > From: Edmund Dea <edmund.j.dea at intel.com>
> >
> > Added macros for date and version
> >
> > Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display")
> > Signed-off-by: Edmund Dea <edmund.j.dea at intel.com>
> > ---
> >   drivers/gpu/drm/kmb/kmb_drv.c | 8 ++++----
> >   drivers/gpu/drm/kmb/kmb_drv.h | 5 +++++
> >   2 files changed, 9 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/kmb/kmb_drv.c
> b/drivers/gpu/drm/kmb/kmb_drv.c
> > index c0b1c6f99249..f54392ec4fab 100644
> > --- a/drivers/gpu/drm/kmb/kmb_drv.c
> > +++ b/drivers/gpu/drm/kmb/kmb_drv.c
> > @@ -425,10 +425,10 @@ static const struct drm_driver kmb_driver = {
> >   	.fops = &fops,
> >   	DRM_GEM_CMA_DRIVER_OPS_VMAP,
> >   	.name = "kmb-drm",
> > -	.desc = "KEEMBAY DISPLAY DRIVER ",
> > -	.date = "20201008",
> > -	.major = 1,
> > -	.minor = 0,
> > +	.desc = "KEEMBAY DISPLAY DRIVER",
> > +	.date = DRIVER_DATE,
> > +	.major = DRIVER_MAJOR,
> > +	.minor = DRIVER_MINOR,
> >   };
> >
> >   static int kmb_remove(struct platform_device *pdev)
> > diff --git a/drivers/gpu/drm/kmb/kmb_drv.h
> b/drivers/gpu/drm/kmb/kmb_drv.h
> > index 02e806712a64..ebbaa5f422d5 100644
> > --- a/drivers/gpu/drm/kmb/kmb_drv.h
> > +++ b/drivers/gpu/drm/kmb/kmb_drv.h
> > @@ -15,6 +15,11 @@
> >   #define KMB_MAX_HEIGHT			1080 /*Max height in pixels */
> >   #define KMB_MIN_WIDTH                   1920 /*Max width in pixels */
> >   #define KMB_MIN_HEIGHT                  1080 /*Max height in pixels */
> > +
> > +#define DRIVER_DATE			"20210223"
> > +#define DRIVER_MAJOR			1
> > +#define DRIVER_MINOR			1
> > +
> >   #define KMB_LCD_DEFAULT_CLK		200000000
> >   #define KMB_SYS_CLK_MHZ			500
> >
> >
> 
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer