[PATCH v4 13/27] drm/mediatek: Don't set struct drm_device.irq_enabled
Chun-Kuang Hu
chunkuang.hu at kernel.org
Mon Aug 9 13:08:48 UTC 2021
Hi, Thomas:
Thomas Zimmermann <tzimmermann at suse.de> 於 2021年6月25日 週五 下午4:22寫道:
>
> The field drm_device.irq_enabled is only used by legacy drivers
> with userspace modesetting. Don't set it in mediatek.
>
Acked-by: Chun-Kuang Hu <chunkuang.hu at kernel.org>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index b46bdb8985da..9b60bec33d3b 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -270,12 +270,6 @@ static int mtk_drm_kms_init(struct drm_device *drm)
> goto err_component_unbind;
> }
>
> - /*
> - * We don't use the drm_irq_install() helpers provided by the DRM
> - * core, so we need to set this manually in order to allow the
> - * DRM_IOCTL_WAIT_VBLANK to operate correctly.
> - */
> - drm->irq_enabled = true;
> ret = drm_vblank_init(drm, MAX_CRTC);
> if (ret < 0)
> goto err_component_unbind;
> --
> 2.32.0
>
More information about the dri-devel
mailing list