[PATCH v3 2/4] drm: rcar-du: lvds: Convert to DRM panel bridge helper

Geert Uytterhoeven geert at linux-m68k.org
Tue Aug 10 15:51:57 UTC 2021


Hi Laurent,

On Tue, Aug 10, 2021 at 5:47 PM Geert Uytterhoeven <geert at linux-m68k.org> wrote:
> On Thu, May 20, 2021 at 8:51 AM Laurent Pinchart
> <laurent.pinchart+renesas at ideasonboard.com> wrote:
> > Replace the manual panel handling with usage of the DRM panel bridge
> > helper. This simplifies the driver, and brings support for
> > DRM_BRIDGE_ATTACH_NO_CONNECTOR as an added bonus.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
>
> Thanks for your patch, which is now commit e9e056949c927e5b ("drm:
> rcar-du: lvds: Convert to DRM panel bridge helper") in drm-next.
>
> This causes the following scary messages in the kernel log on Ebisu-4D:
>
> [drm:drm_bridge_attach] *ERROR* failed to attach bridge

> Reverting this commit fixes the issue.

Oops, that's not true (should not write tentative messages while booting
a test kernel, and press send without checking first ;-)

Reverting the commit doesn't seem to make a difference.
But the parent 5bcc48395b9f35da ("drm: bridge: dw-hdmi: Attach to
next bridge if available") of the bad commit is fine.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds


More information about the dri-devel mailing list