[PATCH v2 55/63] HID: roccat: Use struct_group() to zero kone_mouse_event

Kees Cook keescook at chromium.org
Fri Aug 20 15:19:08 UTC 2021


On Fri, Aug 20, 2021, 6:02 AM Jiri Kosina <jikos at kernel.org> wrote:

> On Tue, 17 Aug 2021, Kees Cook wrote:
>
> > In preparation for FORTIFY_SOURCE performing compile-time and run-time
> > field bounds checking for memset(), avoid intentionally writing across
> > neighboring fields.
> >
> > Add struct_group() to mark region of struct kone_mouse_event that should
> > be initialized to zero.
> >
> > Cc: Stefan Achatz <erazor_de at users.sourceforge.net>
> > Cc: Jiri Kosina <jikos at kernel.org>
> > Cc: Benjamin Tissoires <benjamin.tissoires at redhat.com>
> > Cc: linux-input at vger.kernel.org
> > Signed-off-by: Kees Cook <keescook at chromium.org>
>
> Applied, thank you Kees.
>

Eek! No, this will break the build: struct_group() is not yet in the tree.
I can carry this with an Ack, etc.

-Kees
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20210820/dac7813e/attachment-0001.htm>


More information about the dri-devel mailing list