[PATCH v2 55/63] HID: roccat: Use struct_group() to zero kone_mouse_event

Kees Cook keescook at chromium.org
Fri Aug 20 15:49:52 UTC 2021


On Fri, Aug 20, 2021 at 05:27:35PM +0200, Jiri Kosina wrote:
> On Fri, 20 Aug 2021, Kees Cook wrote:
> 
> > > > In preparation for FORTIFY_SOURCE performing compile-time and run-time
> > > > field bounds checking for memset(), avoid intentionally writing across
> > > > neighboring fields.
> > > >
> > > > Add struct_group() to mark region of struct kone_mouse_event that should
> > > > be initialized to zero.
> > > >
> > > > Cc: Stefan Achatz <erazor_de at users.sourceforge.net>
> > > > Cc: Jiri Kosina <jikos at kernel.org>
> > > > Cc: Benjamin Tissoires <benjamin.tissoires at redhat.com>
> > > > Cc: linux-input at vger.kernel.org
> > > > Signed-off-by: Kees Cook <keescook at chromium.org>
> > >
> > > Applied, thank you Kees.
> > >
> > 
> > Eek! No, this will break the build: struct_group() is not yet in the tree.
> > I can carry this with an Ack, etc.
> 
> I was pretty sure I saw struct_group() already in linux-next, but that was 
> apparently a vacation-induced brainfart, sorry. Dropping.

Cool, no worries. Sorry for the confusion!

-- 
Kees Cook


More information about the dri-devel mailing list