[PATCH V3 0/9] PCI/VGA: Rework default VGA device selection
Bjorn Helgaas
helgaas at kernel.org
Wed Aug 25 20:17:04 UTC 2021
On Fri, Aug 20, 2021 at 06:08:23PM +0800, Huacai Chen wrote:
> My original work is at [1].
>
> Bjorn do some rework and extension in V2. It moves the VGA arbiter to
> the PCI subsystem, fixes a few nits, and breaks a few pieces to make
> the main patch a little smaller.
>
> V3 rewrite the commit log of the last patch (which is also summarized
> by Bjorn).
>
> All comments welcome!
>
> [1] https://lore.kernel.org/dri-devel/20210705100503.1120643-1-chenhuacai@loongson.cn/
>
> Bjorn Helgaas (4):
> PCI/VGA: Move vgaarb to drivers/pci
> PCI/VGA: Replace full MIT license text with SPDX identifier
> PCI/VGA: Use unsigned format string to print lock counts
> PCI/VGA: Remove empty vga_arb_device_card_gone()
>
> Huacai Chen (5):
> PCI/VGA: Move vga_arb_integrated_gpu() earlier in file
> PCI/VGA: Prefer vga_default_device()
> PCI/VGA: Split out vga_arb_update_default_device()
> PCI/VGA: Log bridge control messages when adding devices
> PCI/VGA: Rework default VGA device selection
>
> Signed-off-by: Huacai Chen <chenhuacai at loongson.cn>
> Signed-off-by: Bjorn Helgaas <bhelgaas at google.com>
> ---
> drivers/gpu/vga/Kconfig | 19 ---
> drivers/gpu/vga/Makefile | 1 -
> drivers/pci/Kconfig | 19 +++
> drivers/pci/Makefile | 1 +
> drivers/{gpu/vga => pci}/vgaarb.c | 269 ++++++++++++------------------
> 5 files changed, 126 insertions(+), 183 deletions(-)
> rename drivers/{gpu/vga => pci}/vgaarb.c (90%)
I'm open to merging this series but the v5.15 merge window will
probably open on Sunday, and that's too close for a series of this
size.
Moreover, the critical change is still buried in the middle of the
last patch ("PCI/VGA: Rework default VGA device selection"). There's
way too much going on in that single patch.
As I mentioned in [1], I think you can make a 1- or 2-line patch that
will fix your problem, and I think *that's* the first thing we should
do.
That would be a patch against drivers/gpu/vga/vgaarb.c, so it would be
up to the DRM folks to decide whether to take it for v5.15, but at
least it would be small enough to review it easily.
Bjorn
[1] https://lore.kernel.org/r/20210724001043.GA448782@bjorn-Precision-5520
More information about the dri-devel
mailing list