[PATCH v2 0/2] Use "ref" clocks from firmware for DSI PLL VCO parent
Marijn Suijten
marijn.suijten at somainline.org
Mon Aug 30 18:24:43 UTC 2021
All DSI PHY/PLL drivers were referencing their VCO parent clock by a
global name, most of which don't exist or have been renamed. These
clock drivers seem to function fine without that except the 14nm driver
for the sdm6xx [1].
At the same time all DTs provide a "ref" clock as per the requirements
of dsi-phy-common.yaml, but the clock is never used. This patchset puts
that clock to use without relying on a global clock name, so that all
dependencies are explicitly defined in DT (the firmware) in the end.
[1]: https://lore.kernel.org/linux-arm-msm/386db1a6-a1cd-3c7d-a88e-dc83f8a1be96@somainline.org/
Changes since v1:
- Dropped "arm: dts: qcom: apq8064: Use 27MHz PXO clock as DSI PLL
reference" which has made its way into 5.15-fixes in advance of this
patchset landing in 5.16.
- Added Fixes: tags for commits that added missing "ref" clocks to DT
while this firmware clock was never used (until this patchset).
- Documented missing/wrong and later-added clocks (by aforementioned
patches) in patch 1/2 more clearly.
Dmitry:
I have not added the .name="xo" fallback to the 28nm-hpm driver for
the missing "ref" clock in msm8974 yet. This patch is supposed to
make it in for 5.16 while the missing clock should be added in 5.15,
is that enough time?
If not I'll gladly respin a v3 with that fallback, but I hope everyone
can update their DT firmware before that time. Likewise Bjorn
acknowledged that there is enough time for the same to happen on
apq8064.
Marijn Suijten (2):
drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent
clk: qcom: gcc-sdm660: Remove transient global "xo" clock
drivers/clk/qcom/gcc-sdm660.c | 14 --------------
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 4 +++-
drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 4 +++-
drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 4 +++-
drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 4 +++-
drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 4 +++-
6 files changed, 15 insertions(+), 19 deletions(-)
--
2.33.0
More information about the dri-devel
mailing list