[Intel-gfx] [PATCH 2/3] drm/i915: Sanitycheck device iomem on probe

[Ramalingam C]

On 2021-12-08 at 17:23:26 +0200, Andi Shyti wrote:
> Hi Ram,
> 
> > +static int intel_memory_region_memtest(struct intel_memory_region *mem,
> > +				       void *caller)
> > +{
> > +	struct drm_i915_private *i915 = mem->i915;
> > +	int err = 0;
> > +
> > +	if (!mem->io_start)
> > +		return 0;
> > +
> > +	if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM))
> > +		err = iomemtest(mem, caller);
> 
> I don't understand the debugging part of the iomemtest, if memory
> is failing we wouldn't relise if DEBUG_GEM is not enabled.
Thanks for the review Andi!

Since this is in the system init path, running the time taking mem
test only (on demand basis) when the DEBUG_GEM is set or mod_param
is set as per the next patch.

Ram
> 
> In any case,
> 
> Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>
> 
> Andi