[PATCH] gpu: drm: mcde: add missing of_node_put before return

Qing Wang wangqing at vivo.com
Mon Dec 13 09:43:49 UTC 2021


From: Wang Qing <wangqing at vivo.com>

Fix following coccicheck warning:
WARNING: Function "for_each_available_child_of_node" 
should have of_node_put() before return.

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Signed-off-by: Wang Qing <wangqing at vivo.com>
---
 drivers/gpu/drm/mcde/mcde_dsi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c
index 5651734ce..cac1bde
--- a/drivers/gpu/drm/mcde/mcde_dsi.c
+++ b/drivers/gpu/drm/mcde/mcde_dsi.c
@@ -1110,6 +1110,7 @@ static int mcde_dsi_bind(struct device *dev, struct device *master,
 
 			bridge = of_drm_find_bridge(child);
 			if (!bridge) {
+				of_node_put(child);
 				dev_err(dev, "failed to find bridge\n");
 				return -EINVAL;
 			}
-- 
2.7.4



More information about the dri-devel mailing list