[PATCH 1/3] drm: rcar-du: DRM_RCAR_DW_HDMI should depend on ARCH_RENESAS

Geert Uytterhoeven geert at linux-m68k.org
Wed Dec 15 10:48:30 UTC 2021


Hi Laurent,

On Wed, Dec 15, 2021 at 11:24 AM Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
> On Wed, Dec 15, 2021 at 10:27:45AM +0100, Geert Uytterhoeven wrote:
> > The Renesas R-Car Gen3 and RZ/G2 internal HDMI encoder is only present
> > on Renesas R-Car Gen3 and RZ/G2 SoCs.  Hence add a dependency on
> > ARCH_RENESAS, to prevent asking the user about this driver when
> > configuring a kernel without Renesas SoC support.
> >
> > Fixes: 40d0fa7095d06c73 ("drm: rcar-du: Add Gen3 HDMI encoder support")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>

> > --- a/drivers/gpu/drm/rcar-du/Kconfig
> > +++ b/drivers/gpu/drm/rcar-du/Kconfig
> > @@ -25,6 +25,7 @@ config DRM_RCAR_CMM
> >  config DRM_RCAR_DW_HDMI
> >       tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support"
> >       depends on DRM && OF
> > +     depends on ARCH_RENESAS || COMPILE_TEST
>
> Let's move this entry first to keep alphabetical order.

I tend to keep the "hard" and "soft" dependencies separate, with the
"hard" dependencies listed first.

> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Thank you!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds


More information about the dri-devel mailing list