[PATCH v2 1/2] dt-bindings: display: Turn lvds.yaml into a generic schema
Rob Herring
robh at kernel.org
Fri Dec 17 22:25:06 UTC 2021
On Fri, 17 Dec 2021 14:25:01 +0100, Maxime Ripard wrote:
> The lvds.yaml file so far was both defining the generic LVDS properties
> (such as data-mapping) that could be used for any LVDS sink, but also
> the panel-lvds binding.
>
> That last binding was to describe LVDS panels simple enough, and had a
> number of other bindings using it as a base to specialise it further.
>
> However, this situation makes it fairly hard to extend and reuse both
> the generic parts, and the panel-lvds itself.
>
> Let's remove the panel-lvds parts and leave only the generic LVDS
> properties.
>
> Reviewed-by: Rob Herring <robh at kernel.org>
> Signed-off-by: Maxime Ripard <maxime at cerno.tech>
>
> ---
>
> Changes from v1:
> - Moved the schema out of panel
> ---
> .../bindings/display/{panel => }/lvds.yaml | 31 ++-----------------
> .../display/panel/advantech,idk-1110wr.yaml | 19 ++++++++++--
> .../display/panel/innolux,ee101ia-01d.yaml | 23 ++++++++++++--
> .../display/panel/mitsubishi,aa104xd12.yaml | 19 ++++++++++--
> .../display/panel/mitsubishi,aa121td01.yaml | 19 ++++++++++--
> .../display/panel/sgd,gktw70sdae4se.yaml | 19 ++++++++++--
> 6 files changed, 91 insertions(+), 39 deletions(-)
> rename Documentation/devicetree/bindings/display/{panel => }/lvds.yaml (86%)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml references a file that doesn't exist: Documentation/devicetree/bindings/display/panel/lvds.yaml
Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/display/panel/lvds.yaml
Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml: Documentation/devicetree/bindings/display/panel/lvds.yaml
MAINTAINERS: Documentation/devicetree/bindings/display/panel/lvds.yaml
See https://patchwork.ozlabs.org/patch/1570028
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
More information about the dri-devel
mailing list