[PATCH v3 6/9] backlight: qcom-wled: Remove unnecessary 4th default string in WLED3

Lee Jones lee.jones at linaro.org
Wed Dec 22 11:17:52 UTC 2021


On Mon, 15 Nov 2021, Marijn Suijten wrote:

> The previous commit improves num_strings parsing to not go over the
> maximum of 3 strings for WLED3 anymore.  Likewise this default index for
> a hypothetical 4th string is invalid and could access registers that are
> not mapped to the desired purpose.
> Removing this value gets rid of undesired confusion and avoids the
> possibility of accessing registers at this offset even if the 4th array
> element is used by accident.
> 
> Signed-off-by: Marijn Suijten <marijn.suijten at somainline.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at somainline.org>
> Reviewed-by: Daniel Thompson <daniel.thompson at linaro.org>
> ---
>  drivers/video/backlight/qcom-wled.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog


More information about the dri-devel mailing list