[PATCH] drm/ast: Support 1600x900 with 108MHz PCLK

[Dave Airlie]

On Wed, 22 Dec 2021 at 11:19, Kuo-Hsiang Chou
<kuohsiang_chou at aspeedtech.com> wrote:
>
> Hi
>
> -----Original Message-----
> From: Dave Airlie [mailto:airlied at gmail.com]
> Sent: Wednesday, December 22, 2021 5:56 AM
> To: Thomas Zimmermann <tzimmermann at suse.de>
>
> Subject: Re: [PATCH] drm/ast: Support 1600x900 with 108MHz PCLK
>
> On Mon, 2 Nov 2020 at 17:57, Thomas Zimmermann <tzimmermann at suse.de> wrote:
> >
> > Hi
> >
> > Am 30.10.20 um 08:42 schrieb KuoHsiang Chou:
> > > [New] Create the setting for 1600x900 @60Hz refresh rate
> > >       by 108MHz pixel-clock.
> > >
> > > Signed-off-by: KuoHsiang Chou <kuohsiang_chou at aspeedtech.com>
> >
> > Acked-by: Thomas Zimmermann <tzimmermann at suse.de>
> >
> > I'll add your patch to drm-misc-next.
> >
> > As Sam mentioned, you should use scripts/get_maintainers.pl to
> > retrieve the relevant people. These include those in MAINTAINERS, but
> > also developers that have previously worked on the code.
>
> We are seeing a possible report of a regression on an ast2600 server with this patch.
>
> I haven't ascertained that reverting it fixes it for the customer yet, but this is a heads up in case anyone else has seen issues.
>
> Hi Dave,
>
> Yes, you're right, The patch needs to be removed. The patch occurs incorrect timing on CRT and ASTDP when 1600x900 are selected.
> So, do I need to commit a new patch to remove/revert it from drm/ast?

Yes, do a git revert <commitd>

Fixup the resulting message, to say why, and add a
Fixes: <12 chars of sha1> ("commitmsg")

and send to the list.
Dave.