[PATCH] drm: mxsfb: Shutdown the display on remove

[Laurent Pinchart]

Hi Marek,

Thank you for the patch.

On Fri, Dec 31, 2021 at 05:00:56PM +0100, Marek Vasut wrote:
> When the device is unbound from the driver, the display may be active.
> Make sure it gets shut down.
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Cc: Lucas Stach <l.stach at pengutronix.de>
> Cc: Sam Ravnborg <sam at ravnborg.org>
> Cc: Stefan Agner <stefan at agner.ch>
> Cc: Thomas Zimmermann <tzimmermann at suse.de>
> ---
>  drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index 86d78634a9799..6d7a3aeff50b0 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -374,6 +374,7 @@ static int mxsfb_remove(struct platform_device *pdev)
>  	struct drm_device *drm = platform_get_drvdata(pdev);
>  
>  	drm_dev_unregister(drm);
> +	drm_atomic_helper_shutdown(drm);

That looks reasonable. While at it, should you also implement the
.shutdown driver operation ?

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>  	mxsfb_unload(drm);
>  	drm_dev_put(drm);
>  

-- 
Regards,

Laurent Pinchart