[PATCH 1/6] drm/gma500/cdv: Remove unused code for crt init

[Thomas Zimmermann]

Am 01.02.21 um 14:26 schrieb Patrik Jakobsson:
> Clearly never been used so just remove it.
> 
> Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson at gmail.com>

Reviewed-by: Thomas Zimmermann <tzimmermann at suse.de>

> ---
>   drivers/gpu/drm/gma500/cdv_intel_crt.c | 15 +--------------
>   1 file changed, 1 insertion(+), 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_crt.c b/drivers/gpu/drm/gma500/cdv_intel_crt.c
> index c48c9d322dfb..4a9bb4994a26 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_crt.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_crt.c
> @@ -248,8 +248,6 @@ void cdv_intel_crt_init(struct drm_device *dev,
>   	struct drm_connector *connector;
>   	struct drm_encoder *encoder;
>   
> -	u32 i2c_reg;
> -
>   	gma_encoder = kzalloc(sizeof(struct gma_encoder), GFP_KERNEL);
>   	if (!gma_encoder)
>   		return;
> @@ -269,24 +267,13 @@ void cdv_intel_crt_init(struct drm_device *dev,
>   	gma_connector_attach_encoder(gma_connector, gma_encoder);
>   
>   	/* Set up the DDC bus. */
> -	i2c_reg = GPIOA;
> -	/* Remove the following code for CDV */
> -	/*
> -	if (dev_priv->crt_ddc_bus != 0)
> -		i2c_reg = dev_priv->crt_ddc_bus;
> -	}*/
> -	gma_encoder->ddc_bus = psb_intel_i2c_create(dev,
> -							  i2c_reg, "CRTDDC_A");
> +	gma_encoder->ddc_bus = psb_intel_i2c_create(dev, GPIOA, "CRTDDC_A");
>   	if (!gma_encoder->ddc_bus) {
>   		dev_printk(KERN_ERR, dev->dev, "DDC bus registration failed.\n");
>   		goto failed_ddc;
>   	}
>   
>   	gma_encoder->type = INTEL_OUTPUT_ANALOG;
> -	/*
> -	psb_intel_output->clone_mask = (1 << INTEL_ANALOG_CLONE_BIT);
> -	psb_intel_output->crtc_mask = (1 << 0) | (1 << 1);
> -	*/
>   	connector->interlace_allowed = 0;
>   	connector->doublescan_allowed = 0;
>   
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20210201/9975a639/attachment.sig>