[PATCH 3/6] drm/gma500/cdv: Remove unused tv out paths

Thomas Zimmermann tzimmermann at suse.de
Mon Feb 1 14:39:10 UTC 2021



Am 01.02.21 um 14:26 schrieb Patrik Jakobsson:
> Afaik tv out is not available on Cedarview and the code isn't doing
> anything so remove it.
> 
> Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson at gmail.com>

Reviewed-by: Thomas Zimmermann <tzimmermann at suse.de>

> ---
>   drivers/gpu/drm/gma500/cdv_intel_display.c | 11 +----------
>   1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c
> index 5d3302249779..aac776fab36d 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_display.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_display.c
> @@ -582,7 +582,7 @@ static int cdv_intel_crtc_mode_set(struct drm_crtc *crtc,
>   	struct gma_clock_t clock;
>   	u32 dpll = 0, dspcntr, pipeconf;
>   	bool ok;
> -	bool is_lvds = false, is_tv = false;
> +	bool is_lvds = false;
>   	bool is_dp = false;
>   	struct drm_mode_config *mode_config = &dev->mode_config;
>   	struct drm_connector *connector;
> @@ -603,9 +603,6 @@ static int cdv_intel_crtc_mode_set(struct drm_crtc *crtc,
>   		case INTEL_OUTPUT_LVDS:
>   			is_lvds = true;
>   			break;
> -		case INTEL_OUTPUT_TVOUT:
> -			is_tv = true;
> -			break;
>   		case INTEL_OUTPUT_ANALOG:
>   		case INTEL_OUTPUT_HDMI:
>   			break;
> @@ -660,12 +657,6 @@ static int cdv_intel_crtc_mode_set(struct drm_crtc *crtc,
>   	}
>   
>   	dpll = DPLL_VGA_MODE_DIS;
> -	if (is_tv) {
> -		/* XXX: just matching BIOS for now */
> -/*	dpll |= PLL_REF_INPUT_TVCLKINBC; */
> -		dpll |= 3;
> -	}
> -/*		dpll |= PLL_REF_INPUT_DREFCLK; */
>   
>   	if (is_dp || is_edp) {
>   		cdv_intel_dp_set_m_n(crtc, mode, adjusted_mode);
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20210201/af353ae1/attachment.sig>


More information about the dri-devel mailing list