[PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE

[Emil Velikov]

Hi James,

On Tue, 2 Feb 2021 at 08:27, James Park <james.park at lagfreegames.com> wrote:
>
> Hello,
>
> Is there something I can do to help move this patch along?
>
> Thanks,
> James Park
>
> On Thu, Dec 10, 2020 at 1:13 AM James Park <jpark37 at lagfreegames.com> wrote:
>>
>> Create drm_basic_types.h to define types previously defined by drm.h.
>>
>> Use DRM_FOURCC_STANDALONE to include drm_fourcc.h without drm.h.
>>
>> This will allow Mesa to port code to Windows more easily.
>>
>> Signed-off-by: James Park <jpark37 at lagfreegames.com>
>> Acked-by: Simon Ser <contact at emersion.fr>
>> Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.com>
>> ---
>>  include/uapi/drm/drm.h             | 12 ++-------
>>  include/uapi/drm/drm_basic_types.h | 52 ++++++++++++++++++++++++++++++++++++++
>>  include/uapi/drm/drm_fourcc.h      |  4 +++
>>  3 files changed, 58 insertions(+), 10 deletions(-)
>>  create mode 100644 include/uapi/drm/drm_basic_types.h
>>
Have you considered the possibility of having the ifdef block inlined
within drm_fourcc.h?

Sure some users might need to add an drm.h include in their code. At
the same time they also need to explicitly define
DRM_FOURCC_STANDALONE, so that is fine.
We had all sorts of issues with these headers in the past, so adding
another one might end up repeating some of those yet again.

Thanks
Emil