[PATCH v4 2/3] drm/bridge: anx7625: fix not correct return value
Robert Foss
robert.foss at linaro.org
Thu Feb 4 12:28:30 UTC 2021
Hi Xin,
On Thu, 28 Jan 2021 at 04:12, Xin Ji <xji at analogixsemi.com> wrote:
>
> At some time, the original code may return non zero value, force return 0
> if operation finished
Missing "." at end of line.
Other than that, this patch looks fine. Feel free to add my r-b.
Reviewed-by: Robert Foss <robert.foss at linaro.org>
>
> Signed-off-by: Xin Ji <xji at analogixsemi.com>
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 65cc059..04536cc 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -189,10 +189,10 @@ static int wait_aux_op_finish(struct anx7625_data *ctx)
> AP_AUX_CTRL_STATUS);
> if (val < 0 || (val & 0x0F)) {
> DRM_DEV_ERROR(dev, "aux status %02x\n", val);
> - val = -EIO;
> + return -EIO;
> }
>
> - return val;
> + return 0;
> }
>
> static int anx7625_video_mute_control(struct anx7625_data *ctx,
> --
> 2.7.4
>
More information about the dri-devel
mailing list