[PATCH][V2] drm/mgag200: make a const array static, makes object smaller
Thomas Zimmermann
tzimmermann at suse.de
Fri Feb 5 14:43:44 UTC 2021
Merged.
Am 04.02.21 um 20:11 schrieb Colin King:
> From: Colin Ian King <colin.king at canonical.com>
>
> Don't populate the const array m_div_val on the stack but instead make
> it static. Makes the object code smaller by 29 bytes:
>
> Before:
> text data bss dec hex filename
> 34736 4552 0 39288 9978 drivers/gpu/drm/mgag200/mgag200_mode.o
>
> After:
> text data bss dec hex filename
> 34625 4616 0 39241 9949 drivers/gpu/drm/mgag200/mgag200_mode.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> Reviewed-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---
>
> V2: move static declaration to the top of the declarations
>
> ---
> drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
> index 1dfc42170059..c3dfde8cad25 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_mode.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
> @@ -706,13 +706,13 @@ static int mga_g200eh_set_plls(struct mga_device *mdev, long clock)
>
> static int mga_g200er_set_plls(struct mga_device *mdev, long clock)
> {
> + static const unsigned int m_div_val[] = { 1, 2, 4, 8 };
> unsigned int vcomax, vcomin, pllreffreq;
> unsigned int delta, tmpdelta;
> int testr, testn, testm, testo;
> unsigned int p, m, n;
> unsigned int computed, vco;
> int tmp;
> - const unsigned int m_div_val[] = { 1, 2, 4, 8 };
>
> m = n = p = 0;
> vcomax = 1488000;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20210205/30342500/attachment-0001.sig>
More information about the dri-devel
mailing list