[PATCH] drm/msm/dp: Add a missing semi-colon
Stephen Boyd
swboyd at chromium.org
Mon Feb 8 18:57:07 UTC 2021
Quoting Joe Perches (2021-02-06 21:06:54)
> On Sat, 2021-02-06 at 20:18 -0800, Stephen Boyd wrote:
> > A missing semicolon here causes my external display to stop working.
> > Indeed, missing the semicolon on the return statement leads to
> > dp_panel_update_tu_timings() not existing because the compiler thinks
> > it's part of the return statement of a void function, so it must not be
> > important.
> >
> > $ ./scripts/bloat-o-meter before.o after.o
> > add/remove: 1/1 grow/shrink: 0/1 up/down: 7400/-7540 (-140)
> > Function old new delta
> > dp_panel_update_tu_timings - 7400 +7400
> > _dp_ctrl_calc_tu.constprop 18024 17900 -124
> > dp_panel_update_tu_timings.constprop 7416 - -7416
> > Total: Before=54440, After=54300, chg -0.26%
> >
> > Add a semicolon so this function works like it used to.
> []
> > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
> []
> > @@ -631,7 +631,7 @@ static void _dp_ctrl_calc_tu(struct dp_tu_calc_input *in,
> >
> >
> > tu = kzalloc(sizeof(*tu), GFP_KERNEL);
> > if (!tu)
> > - return
> > + return;
> >
> >
> > dp_panel_update_tu_timings(in, tu);
>
> Wow, that's really unfortunate that dp_panel_update_tu_timings
> is also void.
>
> Perhaps this as YA checkpatch warning:
>
> ---
Acked-by: Stephen Boyd <swboyd at chromium.org>
More information about the dri-devel
mailing list