[PATCH] drm/tiny: add driver for newhaven,1.8-128160EF

[Thomas Zimmermann]

Hi

Am 12.02.21 um 10:47 schrieb Daniel Mack:
> Hi,
> 
> Thanks for the review!
> 
> On 2/12/21 8:13 AM, Thomas Zimmermann wrote:
>> thanks for the driver. I only have some minor comments
>>
>> Am 11.02.21 um 10:50 schrieb Daniel Mack:
>>> +#define ILI9163_MADCTL_BGR    BIT(3)
>>> +#define ILI9163_MADCTL_MV    BIT(5)
>>> +#define ILI9163_MADCTL_MX    BIT(6)
>>> +#define ILI9163_MADCTL_MY    BIT(7)
>>
>> The indention is inconsistent. Or maybe it's just my email client.
> 
> Yes, the latter :)
> 
> Addressed the rest of your remarks. Will send a v2.

You should also add yourself to MAINTAINERS for this driver.

Best regards
Thomas

> 
> 
> Thanks,
> Daniel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20210212/c4159716/attachment.sig>