[PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211
Robert Foss
robert.foss at linaro.org
Mon Feb 15 11:58:07 UTC 2021
Hey Jagan,
Thanks for submitting this.
checkpatch.pl threw some typ-o warnings, and I listed them below. I
think either spelling is correct, but 'spelling.txt' does list this as
a typ-o explicitly, so I would suggest conforming to that just to
silence the checkpatch warning.
This patch also passes 'dt_binding_check' and 'dtbs_check', but I
think I'd like to defer to Rob Herring for an actual r-b.
On Sun, 14 Feb 2021 at 18:55, Jagan Teki <jagan at amarulasolutions.com> wrote:
>
> ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone.
>
> It has a flexible configuration of MIPI DSI signal input and
> produce RGB565, RGB666, RGB888 output format.
>
> Add dt-bingings for it.
>
> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
> ---
> Changes for v3:
> - updated to new dt-bindings style
>
> .../display/bridge/chipone,icn6211.yaml | 90 +++++++++++++++++++
> 1 file changed, 90 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
> new file mode 100644
> index 000000000000..13764f13fe46
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
> @@ -0,0 +1,90 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge
$ scripts/checkpatch.pl --git HEAD~0
WARNING: 'Convertor' may be misspelled - perhaps 'Converter'?
#7:
ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone.
^^^^^^^^^
> +
> +maintainers:
> + - Jagan Teki <jagan at amarulasolutions.com>
> +
> +description: |
> + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone.
WARNING: 'Convertor' may be misspelled - perhaps 'Converter'?
#38: FILE: Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml:13:
+ ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone.
^^^^^^^^^
> +
> + It has a flexible configuration of MIPI DSI signal input and
> + produce RGB565, RGB666, RGB888 output format.
> +
> +properties:
> + compatible:
> + enum:
> + - chipone,icn6211
> +
> + reg:
> + maxItems: 1
> + description: virtual channel number of a DSI peripheral
> +
> + reset-gpios:
> + description: GPIO connected for the reset pin
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port at 0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Video port for MIPI DSI input
> +
> + port at 1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Video port for MIPI DPI output (panel or connector).
> +
> + required:
> + - port at 0
> + - port at 1
> +
> +required:
> + - compatible
> + - reg
> + - reset-gpios
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge at 0 {
> + compatible = "chipone,icn6211";
> + reg = <0>;
> + reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* LCD-RST: PL5 */
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge_in: port at 0 {
> + reg = <0>;
> +
> + bridge_out_dsi: endpoint {
> + remote-endpoint = <&dsi_out_bridge>;
> + };
> + };
> +
> + bridge_out: port at 1 {
> + reg = <1>;
> +
> + bridge_out_panel: endpoint {
> + remote-endpoint = <&panel_out_bridge>;
> + };
> + };
> + };
> + };
> + };
> --
> 2.25.1
>
More information about the dri-devel
mailing list