[PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

Deepak Rawat drawat.floss at gmail.com
Wed Feb 17 16:10:08 UTC 2021


On Wed, 2021-02-17 at 13:22 +0000, Simon Ser wrote:
> On Tuesday, February 16th, 2021 at 1:39 AM, Deepak Rawat <
> drawat.floss at gmail.com> wrote:
> 
> > +static int hyperv_conn_init(struct hyperv_drm_device *hv)
> > +{
> > +       drm_connector_helper_add(&hv->connector,
> > &hyperv_connector_helper_funcs);
> > +       return drm_connector_init(&hv->dev, &hv->connector,
> > +                                 &hyperv_connector_funcs,
> > +                                 DRM_MODE_CONNECTOR_VGA);
> > +}
> 
> Nit: shouldn't this be DRM_MODE_CONNECTOR_Virtual?

Thanks Simon for the review, I think it make sense to use
DRM_MODE_CONNECTOR_Virtual.





More information about the dri-devel mailing list